New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid empty string fom inputs #9

Merged

mshanemc merged 1 commit into main from sm/empty-string-in-env

Oct 25, 2022

Contributor

mshanemc commented Oct 25, 2022 •

edited

Loading

empty inputs are empty string, which is getting set in the env

see issue actions/runner#924

So then cli-plugins-testkit retrieves an empty string here: https://github.com/salesforcecli/cli-plugins-testkit/blob/c308c163698a9cb27aae50c912bd2857b829622d/src/execCmd.ts#L123

resulting in this kind of error: https://github.com/salesforcecli/plugin-limits/actions/runs/3305709998/jobs/5456042134

I made a branch on the failing repo to verify this fix's correctness: salesforcecli/plugin-limits#352 which should be delete when you merge this.


          fix: avoid empty string fom inputs

336096e

git2gus bot commented Oct 25, 2022

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

WillieRuemmele approved these changes

View reviewed changes

mshanemc merged commit e410720 into main

mshanemc deleted the sm/empty-string-in-env branch

October 25, 2022 18:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet